Skip to content

Conversation

JanaHoch
Copy link
Contributor

@JanaHoch JanaHoch commented Sep 6, 2025

SUMMARY

Added new module proxmox_vnet to create/update/delete vnets in proxmox SDN

ISSUE TYPE
  • New Module Pull Request
COMPONENT NAME

proxmox_vnet

ADDITIONAL INFORMATION

This is part of #30
Note: If you are trying to test this. it needs sdn locking functions which I've added in #176

Copy link

codecov bot commented Sep 8, 2025

Codecov Report

❌ Patch coverage is 87.07483% with 19 lines in your changes missing coverage. Please review.
✅ Project coverage is 65.36%. Comparing base (b190cb3) to head (a42f824).

Files with missing lines Patch % Lines
plugins/modules/proxmox_vnet.py 79.51% 14 Missing and 3 partials ⚠️
tests/unit/plugins/modules/test_proxmox_vnet.py 96.87% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #182      +/-   ##
==========================================
+ Coverage   64.86%   65.36%   +0.50%     
==========================================
  Files          69       71       +2     
  Lines        6941     7088     +147     
  Branches     1326     1342      +16     
==========================================
+ Hits         4502     4633     +131     
- Misses       2226     2235       +9     
- Partials      213      220       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@JanaHoch JanaHoch marked this pull request as draft September 10, 2025 05:14
@JanaHoch
Copy link
Contributor Author

Hi @IamLunchbox / @Thulium-Drake , This is also ready but it needs 1 function from module_utils which I added in #183 and checks are failing because of that. let me know once #183 is merged this should be good to go next.

@JanaHoch JanaHoch marked this pull request as ready for review September 21, 2025 11:20
Copy link
Contributor

@IamLunchbox IamLunchbox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some minor suggestions, otherwise LGTM

@JanaHoch
Copy link
Contributor Author

Please re-trigger CI task once #183 is merged it should be good then.

@Thulium-Drake
Copy link
Collaborator

@JanaHoch Done!

@IamLunchbox
Copy link
Contributor

@Thulium-Drake this pr is ready from my side.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants